Christian Ferrari
2018-10-18 21:05:36 UTC
Da: Christian Ferrari <***@yahoo.com>A: autoconf-archive-***@gnu.or <autoconf-archive-***@gnu.or>Cc: sebastian-***@web.de <sebastian-***@web.de>; ***@laboissiere.net <***@laboissiere.net>Inviato: giovedì 18 ottobre 2018, 23:02:51 CESTOggetto: Patch for "ax_swig_python.m4"
In the event that "swig" is not available, SWIG variable is blank, but the macro sets it to " -c++".Further checks on SWIG variable, like:Â Â Â Â if test "z$SWIG" != "z"
are passed even if "swig" is not available.At some point a build procedure fails because it does not skip the part that requires "swig", and the command " -c++" is issued.
The macro can be fixed with a small patch: just change SWIG variable only if it's not blank.
***@ubuntu1404-64:~/lixa/m4include$ diff /home/tiian/autoconf-archive/m4/ax_swig_enable_cxx.m4 ax_swig_enable_cxx.m4 52c52,54
<Â Â Â Â Â Â Â Â SWIG="$SWIG -c++"
---
-------------------------------------------------------------
Good design can't stop bad implementation
In the event that "swig" is not available, SWIG variable is blank, but the macro sets it to " -c++".Further checks on SWIG variable, like:Â Â Â Â if test "z$SWIG" != "z"
are passed even if "swig" is not available.At some point a build procedure fails because it does not skip the part that requires "swig", and the command " -c++" is issued.
The macro can be fixed with a small patch: just change SWIG variable only if it's not blank.
***@ubuntu1404-64:~/lixa/m4include$ diff /home/tiian/autoconf-archive/m4/ax_swig_enable_cxx.m4 ax_swig_enable_cxx.m4 52c52,54
<Â Â Â Â Â Â Â Â SWIG="$SWIG -c++"
---
        if test "z$SWIG" != "z"; then
                SWIG="$SWIG -c++"
        fi
Kind RegardsCh.F.                SWIG="$SWIG -c++"
        fi
-------------------------------------------------------------
Good design can't stop bad implementation