[patch #10065] fix shell syntax in AX_JNI_INCLUDE_DIR

[anonymous]

URL:
<https://savannah.gnu.org/patch/?10065>

Summary: fix shell syntax in AX_JNI_INCLUDE_DIR
Project: GNU Autoconf Archive
Submitted by: None
Submitted on: Wed 12 May 2021 04:39:36 PM UTC
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email: ***@math.hu-berlin.de
Open/Closed: Open
Discussion Lock: Any

_______________________________________________________

Details:

In ax_jni_include_dir.m4:77, the line

if @<:@ "$macos_version" -gt "7" @:>@; then

ends up as

if [ "$macos_version" -gt "7" ]; then

in configure.
This does not execute nicely:

../configure: line 26105: [: : integer expression expected

Probably [[ ... ]] was meant, but it would be even nicer to use the portable
explicit call of test here, too.





_______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 12 May 2021 04:39:36 PM UTC Name: ax_jni_include_dir.m4.patch
Size: 628B By: None

<http://savannah.gnu.org/patch/download.php?file_id=51427>

_______________________________________________________

Reply to this item at:

<https://savannah.gnu.org/patch/?10065>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

[anonymous]

Follow-up Comment #1, patch #10065 (project autoconf-archive):

On investigating further, the single brackets are actually ok. It's just that
$macos_version is an empty string because the parsing magic before that didn't
work (sw_vers is 11.3 here, but the sed command looks for some x.y.z; further,
it would then set macos_version=y, which was ok when the macOS version was
10.y.z).

Still might make sense to apply the patch and switch to use `test`.

_______________________________________________________

Reply to this item at:

<https://savannah.gnu.org/patch/?10065>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/